Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 679873002: Clone tokens when cloning ASTs for constants (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clone tokens when cloning ASTs for constants R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=41304

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+856 lines, -274 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/ast/AstCloner.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/utilities/ast/AstClonerTest.java View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 12 chunks +795 lines, -266 lines 4 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 2 chunks +42 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-10-25 21:03:18 UTC) #2
Paul Berry
LGTM! Thanks for doing this, Brian. https://codereview.chromium.org/679873002/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/679873002/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode1039 pkg/analyzer/lib/src/generated/ast.dart:1039: * Clone the ...
6 years, 1 month ago (2014-10-26 17:02:34 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/679873002/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/679873002/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode1039 pkg/analyzer/lib/src/generated/ast.dart:1039: * Clone the given [token] if tokens are suppose ...
6 years, 1 month ago (2014-10-26 18:41:15 UTC) #4
Brian Wilkerson
6 years, 1 month ago (2014-10-26 19:22:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 41304 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698