pkg/analyzer/lib/src/generated/testing/ast_factory.dart - Issue 679873002: Clone tokens when cloning ASTs for constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/testing/ast_factory.dart

Issue 679873002: Clone tokens when cloning ASTs for constants (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analyzer/lib/src/generated/ast.dart ('K') | « pkg/analyzer/lib/src/generated/constant.dart ('k') | pkg/analyzer/test/generated/utilities_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/src/generated/testing/ast_factory.dart

diff --git a/pkg/analyzer/lib/src/generated/testing/ast_factory.dart b/pkg/analyzer/lib/src/generated/testing/ast_factory.dart

index 18490e3d5b54ae6c72a864e0c9968b6e6ea7376c..ed4571ad6f41916fa660bf1baed9991c972ac6e3 100644

--- a/pkg/analyzer/lib/src/generated/testing/ast_factory.dart

+++ b/pkg/analyzer/lib/src/generated/testing/ast_factory.dart

@@ -363,7 +363,7 @@ class AstFactory {

for (String component in components) {

identifierList.add(TokenFactory.tokenFromTypeAndString(TokenType.IDENTIFIER, component));

}

- return new SymbolLiteral(TokenFactory.tokenFromType(TokenType.HASH), new List.from(identifierList));

+ return new SymbolLiteral(TokenFactory.tokenFromType(TokenType.HASH), identifierList);

}

static BlockFunctionBody syncBlockFunctionBody(List<Statement> statements) => new BlockFunctionBody(TokenFactory.tokenFromTypeAndString(TokenType.IDENTIFIER, "sync"), null, block(statements));

« pkg/analyzer/lib/src/generated/ast.dart ('K') | « pkg/analyzer/lib/src/generated/constant.dart ('k') | pkg/analyzer/test/generated/utilities_test.dart » ('j') | no next file with comments »