Issue 679143003: Fix test warnings and expect Safari mobile simulator bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 679143003: Fix test warnings and expect Safari mobile simulator bug. (Closed)

Created:
6 years, 1 month ago by Lasse Reichstein Nielsen

Modified:
6 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix test warnings and expect Safari mobile simulator bug. Committed: https://code.google.com/p/dart/source/detail?r=41319

Patch Set 1 #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	tests/corelib/corelib.status	View	1 chunk	+3 lines, -0 lines	2 comments	Download
M	tests/lib/convert/json_chunk_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/convert/json_utf8_chunk_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

Crashing in the wrong way, or only on Safari mobile simulator. TBR

6 years, 1 month ago (2014-10-27 15:07:00 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #1 manually as r41319 (presubmit successful).

6 years, 1 month ago (2014-10-27 15:07:33 UTC) #3

Bill Hesse

6 years, 1 month ago (2014-10-27 15:44:00 UTC) #4

Message was sent while issue was closed.

I'm making the suggested changes to the status file in cl
https://codereview.chromium.org/679153002/

https://codereview.chromium.org/679143003/diff/1/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/679143003/diff/1/tests/corelib/corelib.status...
tests/corelib/corelib.status:130: [ $compiler == dart2js && $runtime ==
safarimobilesim ]
This is also failing on safari, not just safarimobilesim.

https://codereview.chromium.org/679143003/diff/1/tests/corelib/corelib.status...
tests/corelib/corelib.status:131: string_split_test: RuntimeError  # Appears to
be bug in safarimobilesim
File an issue when adding a line to a status file.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages