Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 674953002: Fix type of String.fromEnvironment() when the name is undefined. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix type of String.fromEnvironment() when the name is undefined. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -5 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +35 lines, -0 lines 0 comments Download
A tests/corelib/from_environment_const_type_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A tests/corelib/from_environment_const_type_undefined_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-23 18:23:55 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-23 18:35:07 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-23 19:36:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41269 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698