Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 670933004: Fix a couple of Dart style naming violations in Intl (Closed)

Created:
6 years, 1 month ago by Alan Knight
Modified:
6 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a couple of Dart style naming violations in Intl BUG= R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=41401

Patch Set 1 #

Patch Set 2 : Duplicate the comment for both variations of parseUtc #

Total comments: 4

Patch Set 3 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M pkg/intl/CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/intl/bin/generate_from_arb.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/date_symbol_data_http_request.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/src/http_request_data_reader.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/src/icu_parser.dart View 4 chunks +8 lines, -9 lines 0 comments Download
M pkg/intl/lib/src/intl/date_format.dart View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Alan Knight
Getting deep into the backlog here...
6 years, 1 month ago (2014-10-29 19:52:33 UTC) #2
Bob Nystrom
Some nits, but LGTM! https://codereview.chromium.org/670933004/diff/20001/pkg/intl/lib/src/intl/date_format.dart File pkg/intl/lib/src/intl/date_format.dart (right): https://codereview.chromium.org/670933004/diff/20001/pkg/intl/lib/src/intl/date_format.dart#newcode293 pkg/intl/lib/src/intl/date_format.dart:293: * format, treating it as ...
6 years, 1 month ago (2014-10-29 20:30:45 UTC) #3
Alan Knight
https://codereview.chromium.org/670933004/diff/20001/pkg/intl/lib/src/intl/date_format.dart File pkg/intl/lib/src/intl/date_format.dart (right): https://codereview.chromium.org/670933004/diff/20001/pkg/intl/lib/src/intl/date_format.dart#newcode293 pkg/intl/lib/src/intl/date_format.dart:293: * format, treating it as being in UTC. The ...
6 years, 1 month ago (2014-10-29 20:43:45 UTC) #4
Alan Knight
6 years, 1 month ago (2014-10-29 20:44:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 41401 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698