Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: pkg/intl/lib/src/icu_parser.dart

Issue 670933004: Fix a couple of Dart style naming violations in Intl (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Review fixes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/intl/lib/src/http_request_data_reader.dart ('k') | pkg/intl/lib/src/intl/date_format.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/lib/src/icu_parser.dart
diff --git a/pkg/intl/lib/src/icu_parser.dart b/pkg/intl/lib/src/icu_parser.dart
index d83c0892366ef2385ff57fc283d9874837b3ed93..0565ce09ace3493c626de8d022cb4d302e22d287 100644
--- a/pkg/intl/lib/src/icu_parser.dart
+++ b/pkg/intl/lib/src/icu_parser.dart
@@ -13,11 +13,11 @@ import 'package:petitparser/petitparser.dart';
/**
* This defines a grammar for ICU MessageFormat syntax. Usage is
- * new ICUParser.message.parse(<string>).value;
+ * new IcuParser.message.parse(<string>).value;
* The "parse" method will return a Success or Failure object which responds
* to "value".
*/
-class ICUParser {
+class IcuParser {
get openCurly => char("{");
get closeCurly => char("}");
@@ -69,7 +69,7 @@ class ICUParser {
gender.map((values) => new Gender.from(values.first, values[3], null));
get selectClause => (id & openCurly & interiorText & closeCurly).map(
(x) => [x.first, x[2]]);
- get generalSelect => preface & selectLiteral & comma &
+ get generalSelect => preface & selectLiteral & comma &
selectClause.plus() & closeCurly;
get intlSelect => generalSelect.map(
(values) => new Select.from(values.first, values[3], null));
@@ -79,7 +79,7 @@ class ICUParser {
get contents => pluralOrGenderOrSelect | parameter | messageText;
get simpleText => (nonIcuMessageText | parameter | openCurly).plus();
get empty => epsilon().map((_) => '');
-
+
get parameter => (openCurly & id & closeCurly).map(
(param) => new VariableSubstitution.named(param[1], null));
@@ -91,17 +91,16 @@ class ICUParser {
Message.from(chunk, null));
/**
- * Represents an ordinary message, i.e. not a plural/gender/select, although
+ * Represents an ordinary message, i.e. not a plural/gender/select, although
* it may have parameters.
*/
get nonIcuMessage => (simpleText | empty).map((chunk) =>
- Message.from(chunk, null));
-
+ Message.from(chunk, null));
+
get stuff => (pluralOrGenderOrSelect | empty).map(
(chunk) => Message.from(chunk, null));
-
- ICUParser() {
+ IcuParser() {
// There is a cycle here, so we need the explicit set to avoid
// infinite recursion.
interiorText.set(contents.plus() | empty);
« no previous file with comments | « pkg/intl/lib/src/http_request_data_reader.dart ('k') | pkg/intl/lib/src/intl/date_format.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698