IR refactoring: consolidate all boxing and unboxing instructions.

IR refactoring: consolidate all boxing and unboxing instructions.

BUG=
R=fschneider@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41437

[Vyacheslav Egorov (Google), 2014-10-30 14:22:35]

vegorov@google.com changed reviewers:
+ fschneider@google.com

[Vyacheslav Egorov (Google), 2014-10-30 14:22:36]

PTAL

[Florian Schneider, 2014-10-30 15:43:23]

lgtm

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:4560: 
Remove extra \n.

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:4627: is_truncating_(representation ==
kUnboxedUint32) {
If you can remove mark_truncating, I'd pass the is_truncating flag explicitly in
the constructor.

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:3880: bool opt) const {
Indentation.

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:3499: bool opt) const {
Indentation.

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_x64.cc:3233: bool opt) const {
Indentation.

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_x64.cc:3349: bool opt) const {
Indentation.

[Vyacheslav Egorov (Google), 2014-10-30 17:57:39]

Please take a look. 

I addressed comments and fixed two issues:

- repaired canonicalization of Unbox(double, Constant(SMI)) ->
UnboxedConstant(double, SMI.ToDoubleValue()).

- repaired value_offset computation in Box/UnboxInstr::ValueOffset(). it was
incorrect to assume that all value_offset() are equal as we define those members
layout using C++ class and as a result C++ compiler can choose a specific
alignment for members that would be different (e.g. on ARM hardware we have
Double::value_offset() != Float32x4::value_offset()).

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:4627: is_truncating_(representation ==
kUnboxedUint32) {
On 2014/10/30 15:43:23, Florian Schneider wrote:
> If you can remove mark_truncating, I'd pass the is_truncating flag explicitly
in
> the constructor.

Done.

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:3880: bool opt) const {
On 2014/10/30 15:43:23, Florian Schneider wrote:
> Indentation.

Done.

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:3499: bool opt) const {
On 2014/10/30 15:43:23, Florian Schneider wrote:
> Indentation.

Done.

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:3499: bool opt) const {
On 2014/10/30 15:43:23, Florian Schneider wrote:
> Indentation.

Done.

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_x64.cc:3233: bool opt) const {
On 2014/10/30 15:43:23, Florian Schneider wrote:
> Indentation.

Done.

https://codereview.chromium.org/670263007/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_x64.cc:3349: bool opt) const {
On 2014/10/30 15:43:23, Florian Schneider wrote:
> Indentation.

Done.

[Florian Schneider, 2014-10-31 11:48:11]

lgtm

https://codereview.chromium.org/670263007/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/670263007/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:4621: intptr_t ValueOffset() const {
I'd make it a static file-local function to share between Box/UnboxInstr.

[Vyacheslav Egorov (Google), 2014-10-31 12:04:41]

Thanks for the review. Landing.

https://codereview.chromium.org/670263007/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/670263007/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:4621: intptr_t ValueOffset() const {
On 2014/10/31 11:48:11, Florian Schneider wrote:
> I'd make it a static file-local function to share between Box/UnboxInstr.

Done.

[Vyacheslav Egorov (Google), 2014-10-31 12:17:24]

Committed patchset #3 (id:40001) manually as 41437 (presubmit successful).