Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: runtime/vm/intrinsifier.cc

Issue 670263007: IR refactoring: consolidate all boxing and unboxing instructions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier.cc
diff --git a/runtime/vm/intrinsifier.cc b/runtime/vm/intrinsifier.cc
index 0ba74eb052303a5b42028b90760b2a9173827146..c195e300e1d605c1d91a1d1d2e863427ec40d9f1 100644
--- a/runtime/vm/intrinsifier.cc
+++ b/runtime/vm/intrinsifier.cc
@@ -451,10 +451,12 @@ bool Intrinsifier::Build_Float64ArraySetIndexed(FlowGraph* flow_graph) {
value_check,
builder.TokenPos()));
Definition* double_value = builder.AddDefinition(
- new UnboxDoubleInstr(new Value(value), Isolate::kNoDeoptId));
+ UnboxInstr::Create(kUnboxedDouble,
+ new Value(value),
+ Isolate::kNoDeoptId));
// Manually adjust reaching type because there is no type propagation
// when building intrinsics.
- double_value->AsUnboxDouble()->value()->SetReachingType(
+ double_value->AsUnbox()->value()->SetReachingType(
ZoneCompileType::Wrap(CompileType::FromCid(kDoubleCid)));
builder.AddInstruction(
@@ -494,7 +496,7 @@ bool Intrinsifier::Build_Float64ArrayGetIndexed(FlowGraph* flow_graph) {
Isolate::kNoDeoptId,
builder.TokenPos()));
Definition* result = builder.AddDefinition(
- new BoxDoubleInstr(new Value(unboxed_value)));
+ BoxInstr::Create(kUnboxedDouble, new Value(unboxed_value)));
builder.AddIntrinsicReturn(new Value(result));
return true;
}
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698