Set command-line breakpoints using the path suffix.

Set command-line breakpoints using the path suffix.

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41217

[devoncarew, 2014-10-20 20:59:04]

devoncarew@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2014-10-20 21:07:13]

https://codereview.chromium.org/669613006/diff/20001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerBreakpointManager.java
(right):

https://codereview.chromium.org/669613006/diff/20001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerBreakpointManager.java:414:
return file.getProjectRelativePath().toPortableString();
What if we have 2 projects with lib/test.dart and one of them uses another?
Will it set breakpoints in both lib/test.dart files?

[devoncarew, 2014-10-20 21:37:35]

https://codereview.chromium.org/669613006/diff/20001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerBreakpointManager.java
(right):

https://codereview.chromium.org/669613006/diff/20001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerBreakpointManager.java:414:
return file.getProjectRelativePath().toPortableString();
On 2014/10/20 21:07:13, scheglov wrote:
> What if we have 2 projects with lib/test.dart and one of them uses another?
> Will it set breakpoints in both lib/test.dart files?

Current behavior is that we set breakpoints for the current project, and any
breakpoints that might be packages breakpoints. In the above scenario, we should
set lib/test.dart, package:foo/test.dart, and package:bar/test.dart.

[scheglov, 2014-10-20 21:39:56]

LGTM

[devoncarew, 2014-10-20 22:59:56]

Committed patchset #2 (id:20001) manually as r41217 (presubmit successful).