Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/dialogs/RemoteConnectionDialog.java

Issue 669613006: Set command-line breakpoints using the path suffix. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/dialogs/RemoteConnectionDialog.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/dialogs/RemoteConnectionDialog.java (revision 41204)
+++ editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/dialogs/RemoteConnectionDialog.java (working copy)
@@ -21,8 +21,7 @@
import com.google.dart.tools.debug.core.webkit.DefaultChromiumTabChooser;
import com.google.dart.tools.debug.core.webkit.IChromiumTabChooser;
import com.google.dart.tools.debug.ui.internal.DartDebugUIPlugin;
-import com.google.dart.tools.debug.ui.internal.view.DebuggerView;
-import com.google.dart.tools.ui.DartToolsPlugin;
+import com.google.dart.tools.debug.ui.internal.view.DebuggerViewManager;
import com.google.dart.tools.ui.themes.Fonts;
import org.eclipse.core.runtime.CoreException;
@@ -137,14 +136,17 @@
@Override
protected IStatus run(IProgressMonitor monitor) {
try {
-
connectionDelegate.performRemoteConnection(host, port, monitor, usePubServe);
// Show the debugger view.
Display.getDefault().asyncExec(new Runnable() {
@Override
public void run() {
- DartToolsPlugin.showView(DebuggerView.ID);
+ DebuggerViewManager viewManager = DebuggerViewManager.getDefault();
+
+ if (viewManager.hasDebuggerView()) {
+ viewManager.openDebuggerView();
+ }
}
});
} catch (CoreException ce) {

Powered by Google App Engine
This is Rietveld 408576698