Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 669613003: Ignore redundant parallel moves when checking if a block is empty. (Closed)

Created:
6 years, 2 months ago by Vyacheslav Egorov (Chromium)
Modified:
6 years, 2 months ago
Reviewers:
zerny-google
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Ignore redundant parallel moves when checking if a block is empty. Single predecessor blocks containing nothing but redundant parallel moves can be compacted away. R=zerny@google.com BUG=http://dartbug.com/21302 Committed: https://code.google.com/p/dart/source/detail?r=41187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 3 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
6 years, 2 months ago (2014-10-20 11:00:40 UTC) #1
zerny-google
lgtm
6 years, 2 months ago (2014-10-20 11:08:29 UTC) #2
Vyacheslav Egorov (Chromium)
6 years, 2 months ago (2014-10-20 11:29:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41187 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698