Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 669613003: Ignore redundant parallel moves when checking if a block is empty. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/cha.h" 10 #include "vm/cha.h"
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 FLAG_deoptimize_filter != NULL && 218 FLAG_deoptimize_filter != NULL &&
219 strstr(parsed_function().function().ToFullyQualifiedCString(), 219 strstr(parsed_function().function().ToFullyQualifiedCString(),
220 FLAG_deoptimize_filter) != NULL) { 220 FLAG_deoptimize_filter) != NULL) {
221 return true; 221 return true;
222 } 222 }
223 return false; 223 return false;
224 } 224 }
225 225
226 226
227 static bool IsEmptyBlock(BlockEntryInstr* block) { 227 static bool IsEmptyBlock(BlockEntryInstr* block) {
228 return !block->HasParallelMove() && 228 return !block->HasNonRedundantParallelMove() &&
229 block->next()->IsGoto() && 229 block->next()->IsGoto() &&
230 !block->next()->AsGoto()->HasParallelMove(); 230 !block->next()->AsGoto()->HasNonRedundantParallelMove();
231 } 231 }
232 232
233 233
234 void FlowGraphCompiler::CompactBlock(BlockEntryInstr* block) { 234 void FlowGraphCompiler::CompactBlock(BlockEntryInstr* block) {
235 BlockInfo* block_info = block_info_[block->postorder_number()]; 235 BlockInfo* block_info = block_info_[block->postorder_number()];
236 236
237 // Break out of cycles in the control flow graph. 237 // Break out of cycles in the control flow graph.
238 if (block_info->is_marked()) { 238 if (block_info->is_marked()) {
239 return; 239 return;
240 } 240 }
(...skipping 1250 matching lines...) Expand 10 before | Expand all | Expand 10 after
1491 threshold = FLAG_optimization_counter_scale * basic_blocks + 1491 threshold = FLAG_optimization_counter_scale * basic_blocks +
1492 FLAG_min_optimization_counter_threshold; 1492 FLAG_min_optimization_counter_threshold;
1493 if (threshold > FLAG_optimization_counter_threshold) { 1493 if (threshold > FLAG_optimization_counter_threshold) {
1494 threshold = FLAG_optimization_counter_threshold; 1494 threshold = FLAG_optimization_counter_threshold;
1495 } 1495 }
1496 } 1496 }
1497 return threshold; 1497 return threshold;
1498 } 1498 }
1499 1499
1500 } // namespace dart 1500 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698