Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 667983002: Arity indexing in dart:blink entry points (Closed)

Created:
6 years, 2 months ago by Leaf
Modified:
6 years, 2 months ago
Reviewers:
vsm, terry
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Arity indexing in dart:blink entry points This CL replaces type mangling on the blink entry points with arity indexing. So overloaded methods or methods with optional arguments now dispatch to blink entries specific to their number of arguments (but not their types). This relies on C++ overload resolution being in place on the blink side (see https://codereview.chromium.org/668733002/). For the time being, the dart side overload resolution code is left in place. Resolver strings now have no type or arity info as well. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3764 lines, -3526 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 270 chunks +1663 lines, -1651 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 748 chunks +1470 lines, -1295 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 8 chunks +97 lines, -66 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 136 chunks +211 lines, -211 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 43 chunks +71 lines, -71 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 23 chunks +163 lines, -163 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 4 chunks +44 lines, -25 lines 0 comments Download
M tools/dom/scripts/css_code_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/systemnative.py View 9 chunks +34 lines, -32 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Leaf
6 years, 2 months ago (2014-10-21 17:16:39 UTC) #2
vsm
lgtm
6 years, 2 months ago (2014-10-21 19:46:45 UTC) #3
Leaf
6 years, 2 months ago (2014-10-21 20:47:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41236 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698