Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 667463004: Code clean-up (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1017 lines, -612 lines) Patch
M pkg/analysis_server/lib/src/services/generated/completion.dart View 3 chunks +8 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/services/generated/util.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 9 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 8 chunks +26 lines, -23 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 2 chunks +0 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 44 chunks +490 lines, -92 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 21 chunks +128 lines, -59 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest.dart View 4 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 22 chunks +332 lines, -387 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-10-27 22:30:42 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-10-28 00:07:58 UTC) #3
Brian Wilkerson
6 years, 1 month ago (2014-10-28 00:25:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41348 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698