Code clean-up

pkg/analyzer/test/generated/all_the_rest.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.all_the_rest_test;
 
 import 'dart:collection';
@@ skipping 3019 matching lines @@
    * Finds an [Element] with the given names inside of the given root [Element].
    *
    * TODO(scheglov) maybe move this method to Element
    *
    * @param root the root [Element] to start searching from
    * @param kind the kind of the [Element] to find, if `null` then any kind
    * @param name the name of an [Element] to find
    * @return the found [Element] or `null` if not found
    */
   static Element findElement(Element root, ElementKind kind, String name) {
-    List<Element> result = [null];
-    root.accept(new _AngularTest_findElement(kind, name, result));
-    return result[0];
+    _AngularTest_findElement visitor = new _AngularTest_findElement(kind, name);
+    root.accept(visitor);
+    return visitor.result;
   }
 
   /**
    * Finds an [Element] with the given names inside of the given root [Element].
    *
    * @param root the root [Element] to start searching from
    * @param name the name of an [Element] to find
    * @return the found [Element] or `null` if not found
    */
   static Element findElement2(Element root, String name) {
@@ skipping 7505 matching lines @@
     } on IllegalArgumentException catch (exception) {
     }
   }
   void test_fromEncoding_valid() {
     String encoding = "file:///does/not/exist.dart";
     SourceFactory factory = new SourceFactory(
         [new UriResolver_SourceFactoryTest_test_fromEncoding_valid(encoding)]);
     JUnitTestCase.assertNotNull(factory.fromEncoding(encoding));
   }
   void test_resolveUri_absolute() {
-    List<bool> invoked = [false];
+    UriResolver_absolute resolver = new UriResolver_absolute();
     SourceFactory factory =
-        new SourceFactory([new UriResolver_absolute(invoked)]);
+        new SourceFactory([resolver]);
     factory.resolveUri(null, "dart:core");
-    JUnitTestCase.assertTrue(invoked[0]);
+    JUnitTestCase.assertTrue(resolver.invoked);
   }
   void test_resolveUri_nonAbsolute_absolute() {
     SourceFactory factory =
         new SourceFactory([new UriResolver_nonAbsolute_absolute()]);
     String absolutePath = "/does/not/matter.dart";
     Source containingSource =
         new FileBasedSource.con1(FileUtilities2.createFile("/does/not/exist.dart"));
     Source result = factory.resolveUri(containingSource, absolutePath);
     JUnitTestCase.assertEquals(
         FileUtilities2.createFile(absolutePath).getAbsolutePath(),
@@ skipping 114 matching lines @@
   Source resolveAbsolute(Uri uri) {
     if (uri.toString() == encoding) {
       return new TestSource();
     }
     return null;
   }
 }
 
 
 class UriResolver_absolute extends UriResolver {
-  List<bool> invoked;
+  bool invoked = false;
 
-  UriResolver_absolute(this.invoked);
+  UriResolver_absolute();
 
   @override
   Source resolveAbsolute(Uri uri) {
-    invoked[0] = true;
+    invoked = true;
     return null;
   }
 }
 
 
 class UriResolver_nonAbsolute_absolute extends UriResolver {
   @override
   Source resolveAbsolute(Uri uri) {
     return new FileBasedSource.con2(uri, new JavaFile.fromUri(uri));
   }
@@ skipping 317 matching lines @@
 class XmlValidator_Tag {
   final String _tag;
   final XmlValidator_Attributes _attributes;
   final String _content;
   final List<XmlValidator_Tag> _children;
   XmlValidator_Tag(this._tag, this._attributes, this._content, this._children);
 }
 
 
 class _AngularTest_findElement extends GeneralizingElementVisitor<Object> {
-  ElementKind kind;
+  final ElementKind kind;
 
-  String name;
+  final String name;
 
-  List<Element> result;
+  Element result;
 
-  _AngularTest_findElement(this.kind, this.name, this.result);
+  _AngularTest_findElement(this.kind, this.name);
 
   @override
   Object visitElement(Element element) {
     if ((kind == null || element.kind == kind) && name == element.name) {
-      result[0] = element;
+      result = element;
     }
     return super.visitElement(element);
   }
 }
 
 
 class _ExpectedScript {
   String _expectedExternalScriptName;
   HtmlUnitBuilderTest_ExpectedLibrary _expectedLibrary;
   _ExpectedScript.con1(HtmlUnitBuilderTest_ExpectedLibrary expectedLibrary) {
@@ skipping 33 matching lines @@
     } else {
       JUnitTestCase.assertNotNullMsg("script ${scriptIndex}", scriptSource);
       String actualExternalScriptName = scriptSource.shortName;
       JUnitTestCase.assertEqualsMsg(
           "script ${scriptIndex}",
           _expectedExternalScriptName,
           actualExternalScriptName);
     }
   }
 }