Port regexp tests from V8 to Dart.

Port regexp tests from V8 to Dart.

This adds V8s suite of regular expressions tests. The tests are skipped
for all none d8 runtimes until irregexp has been ported and enabled for
the other runtimes. The tests are enabled when compiling with dart2js
and running with d8.

BUG=http://dartbug.com/21396
R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41354

[zerny-google, 2014-10-23 09:45:12]

zerny@google.com changed reviewers:
+ iposva@chromium.org, lrn@google.com

[zerny-google, 2014-10-23 09:46:06]

PTAL

[Lasse Reichstein Nielsen, 2014-10-23 13:21:58]

Summary:
- Use the copyright notice from all the original files. They say that they must
be retained. Add Dart above the v8 notice.
- Add a disclaimer below saying that the file was converted to Dart from
JavaScript with minimal changes, and text in the tests do not refer to the Dart
project (this also excuses long lines).

Otherwise LGTM.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/RegExp_...
File tests/corelib/regexp/RegExp_test.dart (right):

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/RegExp_...
tests/corelib/regexp/RegExp_test.dart:3: // BSD-style license that can be found
in the LICENSE file.
What was the license text on the original?

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/compile...
File tests/corelib/regexp/compile-crash_test.dart (right):

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/compile...
tests/corelib/regexp/compile-crash_test.dart:9: description("Test regexp
compiling to make sure it doens't crash like bug 16127");
The description is useless (this isn't even V8 bug 16127, I have no idea where
it's from).

Consider either removing all descriptions, or adding a comment above saying that
this is taken from somewhere else (and, if possible, link to where it's taken
from), and that text in the tests does not refer to the Dart project.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/non-cha...
File tests/corelib/regexp/non-character_test.dart (right):

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/non-cha...
tests/corelib/regexp/non-character_test.dart:25: shouldBeNull(firstMatch("y",
new RegExp(r"[\u10FFFF]")));
Looks deceptively like a six-digit unicode escape. I don't think such a think
exists in JS.
Do you have any idea what the intent of the test is?

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/non-gre...
File tests/corelib/regexp/non-greedy-parentheses_test.dart (right):

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/non-gre...
tests/corelib/regexp/non-greedy-parentheses_test.dart:3: // BSD-style license
that can be found in the LICENSE file.
I found the original for this. It starts with:

// Copyright 2013 the V8 project authors. All rights reserved.
// Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.

and a license different from the Dart LICENSE file.

I think you'll have to include the complete original copyright notice, and just
add Dart to the list - for all the files.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/util.dart
File tests/corelib/regexp/util.dart (right):

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/util.da...
tests/corelib/regexp/util.dart:6: 
Could you rename this to, e.g., "v8_regexp_helper.dart" to show that it isn't
intended for general use.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/util.da...
tests/corelib/regexp/util.dart:9: void assertEquals(actual, expected, [message])
=>
Please don't use => for void methods. Just { ... }, it's cleaner.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/util.da...
tests/corelib/regexp/util.dart:13: void assertThrows(fn, [testid]) =>
Expect.throws(fn);
=> Expect.throws(fn, null, testid);

Might as well use the testid as message.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/util.da...
tests/corelib/regexp/util.dart:14: void assertNull(actual, [testid]) =>
Expect.isNull(actual);
Ditto.

[zerny-google, 2014-10-24 12:38:37]

Thanks for the review. I've updated all headers to be exactly the same as in the
original source. In the case of the pure V8 ones we could probably replace it,
but I'll leave that for a followup CL if desired.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/compile...
File tests/corelib/regexp/compile-crash_test.dart (right):

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/compile...
tests/corelib/regexp/compile-crash_test.dart:9: description("Test regexp
compiling to make sure it doens't crash like bug 16127");
On 2014/10/23 13:21:57, Lasse Reichstein Nielsen wrote:
> The description is useless (this isn't even V8 bug 16127, I have no idea where
> it's from).
> 
> Consider either removing all descriptions, or adding a comment above saying
that
> this is taken from somewhere else (and, if possible, link to where it's taken
> from), and that text in the tests does not refer to the Dart project.

Add the link to the webkit bug

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/non-cha...
File tests/corelib/regexp/non-character_test.dart (right):

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/non-cha...
tests/corelib/regexp/non-character_test.dart:25: shouldBeNull(firstMatch("y",
new RegExp(r"[\u10FFFF]")));
On 2014/10/23 13:21:57, Lasse Reichstein Nielsen wrote:
> Looks deceptively like a six-digit unicode escape. I don't think such a think
> exists in JS.
> Do you have any idea what the intent of the test is?

Nope.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/util.dart
File tests/corelib/regexp/util.dart (right):

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/util.da...
tests/corelib/regexp/util.dart:6: 
On 2014/10/23 13:21:58, Lasse Reichstein Nielsen wrote:
> Could you rename this to, e.g., "v8_regexp_helper.dart" to show that it isn't
> intended for general use.

Done.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/util.da...
tests/corelib/regexp/util.dart:9: void assertEquals(actual, expected, [message])
=>
On 2014/10/23 13:21:58, Lasse Reichstein Nielsen wrote:
> Please don't use => for void methods. Just { ... }, it's cleaner.

Done.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/util.da...
tests/corelib/regexp/util.dart:13: void assertThrows(fn, [testid]) =>
Expect.throws(fn);
On 2014/10/23 13:21:57, Lasse Reichstein Nielsen wrote:
> => Expect.throws(fn, null, testid);
> 
> Might as well use the testid as message.

Done.

https://codereview.chromium.org/667043003/diff/1/tests/corelib/regexp/util.da...
tests/corelib/regexp/util.dart:14: void assertNull(actual, [testid]) =>
Expect.isNull(actual);
On 2014/10/23 13:21:58, Lasse Reichstein Nielsen wrote:
> Ditto.

Done.

[zerny-google, 2014-10-27 07:07:46]

zerny@google.com changed reviewers:
+ iposva@google.com
- iposva@chromium.org

[zerny-google, 2014-10-28 08:46:44]

Prepended Dart copyright to all files that did not already have one.

[Lasse Reichstein Nielsen, 2014-10-28 08:58:13]

LGTM.

[zerny-google, 2014-10-28 12:33:42]

Committed patchset #3 (id:40001) manually as 41354 (presubmit successful).