tests/corelib/regexp/compile-crash_test.dart - Issue 667043003: Port regexp tests from V8 to Dart.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/corelib/regexp/compile-crash_test.dart

Issue 667043003: Port regexp tests from V8 to Dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« tests/corelib/regexp/RegExp_test.dart ('K') | « tests/corelib/regexp/character-match-out-of-order_test.dart ('k') | tests/corelib/regexp/compile_test.dart » ('j') | tests/corelib/regexp/non-character_test.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 import 'util.dart';

	6 import 'package:expect/expect.dart';

	7

	8 void main() {

	9 description("Test regexp compiling to make sure it doens't crash like bug 1612 7");
	Lasse Reichstein Nielsen 2014/10/23 13:21:57 The description is useless (this isn't even V8 bug The description is useless (this isn't even V8 bug 16127, I have no idea where it's from). Consider either removing all descriptions, or adding a comment above saying that this is taken from somewhere else (and, if possible, link to where it's taken from), and that text in the tests does not refer to the Dart project. zerny-google 2014/10/24 12:38:37 Add the link to the webkit bug Show quoted text On 2014/10/23 13:21:57, Lasse Reichstein Nielsen wrote: > The description is useless (this isn't even V8 bug 16127, I have no idea where > it's from). > > Consider either removing all descriptions, or adding a comment above saying that > this is taken from somewhere else (and, if possible, link to where it's taken > from), and that text in the tests does not refer to the Dart project. Add the link to the webkit bug
	10

	11 shouldBeTrue(new RegExp(r"\)[;\s]+") != null);

	12 assertThrows(() => new RegExp(r"["));

	13 assertThrows(() => new RegExp(r"[a"));

	14 assertThrows(() => new RegExp(r"[-"));

	15 shouldBeTrue(new RegExp(r"(a)\1") != null);

	16 shouldBeTrue(new RegExp(r"(a)\1{1,3}") != null);

	17 }

OLD	NEW