add property accessor suggestions

add property accessor suggestions

BUG=dartbug.com/21380
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41344

[danrubel, 2014-10-27 22:03:29]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2014-10-27 22:12:31]

lgtm assuming that propagated types are handled properly.

https://codereview.chromium.org/666863003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
(right):

https://codereview.chromium.org/666863003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/invocation_computer.dart:169:
DartType type = elemVar.type;
Will this do the right thing if the propagated type is better than the static
type?  E.g.

  var x = "foo";
  x.

should offer completions for String.

Assuming this already works properly, it would be nice to have a test for it.

[danrubel, 2014-10-27 22:52:06]

On 2014/10/27 22:12:31, Paul Berry wrote:
> lgtm assuming that propagated types are handled properly.
> 
>
https://codereview.chromium.org/666863003/diff/1/pkg/analysis_server/lib/src/...
> File pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
> (right):
> 
>
https://codereview.chromium.org/666863003/diff/1/pkg/analysis_server/lib/src/...
> pkg/analysis_server/lib/src/services/completion/invocation_computer.dart:169:
> DartType type = elemVar.type;
> Will this do the right thing if the propagated type is better than the static
> type?  E.g.
> 
>   var x = "foo";
>   x.
> 
> should offer completions for String.
> 
> Assuming this already works properly, it would be nice to have a test for it.

Possibly not. I'll add more tests and as needed improvements in a subsequent CL.

[danrubel, 2014-10-27 22:56:30]

Committed patchset #2 (id:20001) manually as 41344 (presubmit successful).