add property accessor suggestions

pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.invocation;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analysis_server/src/services/completion/suggestion_builder.dart';
@@ skipping 144 matching lines @@
             LibraryElementSuggestionBuilder.suggestionsFor(request, library);
             modified = true;
           }
         }
       }
     });
     return new Future.value(modified);
   }
 
   @override
+  Future<bool> visitPropertyAccessorElement(PropertyAccessorElement element) {
+    if (element != null) {
+      PropertyInducingElement elemVar = element.variable;
+      if (elemVar != null) {
+        DartType type = elemVar.type;

[Paul Berry, 2014/10/27 22:12:31]

Will this do the right thing if the propagated type is better than the static
type?  E.g.

  var x = "foo";
  x.

should offer completions for String.

Assuming this already works properly, it would be nice to have a test for it.

+        if (type != null) {
+          ClassElementSuggestionBuilder.suggestionsFor(request, type.element);
+        }
+      }
+      return new Future.value(true);
+    }
+    return new Future.value(false);
+  }
+
+  @override
   Future<bool> visitVariableElement(VariableElement element) {
     DartType type = element.type;
     if (type != null) {
       ClassElementSuggestionBuilder.suggestionsFor(request, type.element);
     }
     return new Future.value(true);
   }
 }