Issue 662543003: VM: Avoid repeated deoptimizations from hoisted array bounds checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 662543003: VM: Avoid repeated deoptimizations from hoisted array bounds checks. (Closed)

Created:
6 years, 2 months ago by Florian Schneider

Modified:
6 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

VM: Avoid repeated deoptimizations from hoisted array bounds checks. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41223

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -8 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Florian Schneider

On 2014/10/16 12:51:52, Florian Schneider wrote: I forgot to add CheckArrayBoundInstr in my last CL.

6 years, 2 months ago (2014-10-16 12:52:24 UTC) #3

Florian Schneider

6 years, 2 months ago (2014-10-21 10:37:03 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r41223 (presubmit successful).