runtime/vm/flow_graph_optimizer.cc - Issue 662543003: VM: Avoid repeated deoptimizations from hoisted array bounds checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 662543003: VM: Avoid repeated deoptimizations from hoisted array bounds checks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 41133)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -5046,9 +5046,9 @@

current->AsCheckSmi()->set_licm_hoisted(true);

} else if (current->IsCheckEitherNonSmi()) {

current->AsCheckEitherNonSmi()->set_licm_hoisted(true);

+ } else if (current->IsCheckArrayBound()) {

+ current->AsCheckArrayBound()->set_licm_hoisted(true);

}

- // TODO(fschneider): Avoid repeated deoptimization when

- // speculatively hoisting checks.

if (FLAG_trace_optimization) {

OS::Print("Hoisting instruction %s:%" Pd " from B%" Pd " to B%" Pd "\n",

current->DebugName(),

« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »