Issue 66033006: Check type bounds of redirecting factories (issue 14699).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66033006: Check type bounds of redirecting factories (issue 14699). (Closed)

Created:
7 years, 1 month ago by regis

Modified:
7 years, 1 month ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Check type bounds of redirecting factories (issue 14699). Add tests for malbounded redirecting factories. Clean up bound checking code and type error reporting code. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=30177

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+244 lines, -148 lines)			Patch
runtime/lib/errors.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
runtime/lib/errors_patch.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
runtime/lib/mirrors.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
runtime/vm/ast.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
runtime/vm/class_finalizer.cc	View	1	7 chunks	+33 lines, -41 lines	0 comments	Download
runtime/vm/dart_api_impl.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
runtime/vm/exceptions.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
runtime/vm/exceptions.cc	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download
runtime/vm/object.h	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
runtime/vm/object.cc	View	1	6 chunks	+78 lines, -61 lines	0 comments	Download
runtime/vm/parser.cc	View	1	5 chunks	+35 lines, -22 lines	0 comments	Download
tests/language/language_analyzer.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
tests/language/language_dart2js.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
tests/language/malbounded_redirecting_factory2_test.dart	View		1 chunk	+33 lines, -0 lines	0 comments	Download
tests/language/malbounded_redirecting_factory_test.dart	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

regis

7 years, 1 month ago (2013-11-11 22:59:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30177 (presubmit successful).