runtime/vm/ast.h - Issue 66033006: Check type bounds of redirecting factories (issue 14699).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/ast.h

Issue 66033006: Check type bounds of redirecting factories (issue 14699). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/ast.h

===================================================================

--- runtime/vm/ast.h (revision 30176)

+++ runtime/vm/ast.h (working copy)

@@ -377,8 +377,8 @@

const char* TypeName() const;

virtual const Instance* EvalConstExpr() const {

- // TODO(regis): What if the type is malbounded?

- if (!type_.IsInstantiated() || type_.IsMalformed()) {

+ if (!type_.IsInstantiated() ||

+ type_.IsMalformed() || type_.IsMalbounded()) {

return NULL;

}

return &type();

« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »