pkg/shelf: only catch errors in createMiddleware if an errorHandler is provided

pkg/shelf: only catch errors in createMiddleware if an errorHandler is provided

BUG= https://code.google.com/p/dart/issues/detail?id=21294
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41111

[kevmoo, 2014-10-14 19:27:33]

kevmoo@google.com changed reviewers:
+ nweiz@google.com

[kevmoo, 2014-10-14 19:27:33]

kevmoo@google.com changed required reviewers:
+ nweiz@google.com

[nweiz, 2014-10-14 21:21:19]

lgtm

https://codereview.chromium.org/657543004/diff/1/pkg/shelf/lib/src/middleware...
File pkg/shelf/lib/src/middleware.dart (right):

https://codereview.chromium.org/657543004/diff/1/pkg/shelf/lib/src/middleware...
pkg/shelf/lib/src/middleware.dart:57: if (errorHandler == null) errorHandler =
(error, stackTrace) => throw error;
Remove this; it's redundant with the [onError] stuff below.

[kevmoo, 2014-10-14 22:07:05]

https://codereview.chromium.org/657543004/diff/1/pkg/shelf/lib/src/middleware...
File pkg/shelf/lib/src/middleware.dart (right):

https://codereview.chromium.org/657543004/diff/1/pkg/shelf/lib/src/middleware...
pkg/shelf/lib/src/middleware.dart:57: if (errorHandler == null) errorHandler =
(error, stackTrace) => throw error;
On 2014/10/14 21:21:18, nweiz wrote:
> Remove this; it's redundant with the [onError] stuff below.

Done.

[kevmoo, 2014-10-14 22:07:19]

Committed patchset #2 (id:20001) manually as 41111 (presubmit successful).