Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: pkg/shelf/test/create_middleware_test.dart

Issue 657543004: pkg/shelf: only catch errors in createMiddleware if an errorHandler is provided (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address CL comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/shelf/pubspec.yaml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/shelf/test/create_middleware_test.dart
diff --git a/pkg/shelf/test/create_middleware_test.dart b/pkg/shelf/test/create_middleware_test.dart
index ee01d07d99ca10a34141f636c82e1dd0c57bd4da..a743dd5de6df36d967a5a5452760809a9c0dc1d8 100644
--- a/pkg/shelf/test/create_middleware_test.dart
+++ b/pkg/shelf/test/create_middleware_test.dart
@@ -203,9 +203,21 @@ void main() {
expect(makeSimpleRequest(handler), throwsA('bad handler'));
});
+ test('error thrown by inner handler without a middleware errorHandler is '
+ 'rethrown', () {
+ var middleware = createMiddleware();
+
+ var handler = const Pipeline().addMiddleware(middleware)
+ .addHandler((request) {
+ throw 'bad handler';
+ });
+
+ expect(makeSimpleRequest(handler), throwsA('bad handler'));
+ });
+
test("doesn't handle HijackException", () {
var middleware = createMiddleware(errorHandler: (error, stack) {
- expect(false, "error handler shouldn't be called");
+ fail("error handler shouldn't be called");
});
var handler = const Pipeline().addMiddleware(middleware)
« no previous file with comments | « pkg/shelf/pubspec.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698