Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 657373003: Cleanup constant building in IrBuilder. (Closed)

Created:
6 years, 2 months ago by Johnni Winther
Modified:
6 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleanup constant building in IrBuilder. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41184

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -45 lines) Patch
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart View 1 6 chunks +26 lines, -36 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
6 years, 2 months ago (2014-10-17 13:10:37 UTC) #2
floitsch
LGTM.
6 years, 2 months ago (2014-10-17 15:36:25 UTC) #3
Johnni Winther
6 years, 2 months ago (2014-10-20 07:21:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41184 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698