Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2539)

Unified Diff: sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart

Issue 657373003: Cleanup constant building in IrBuilder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart
diff --git a/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart b/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart
index 6ec3070f9fd7e9a9a3762a60b1c9307a623cbe48..795de5c5d654351c60879782fa51744f00c1d403 100644
--- a/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart
+++ b/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart
@@ -280,9 +280,7 @@ class IrBuilderVisitor extends ResolvedVisitor<ir.Primitive>
ir.Primitive condition;
if (node.condition == null) {
// If the condition is empty then the body is entered unconditionally.
- condition = irBuilder.makePrimConst(
- irBuilder.state.constantSystem.createBool(true));
- condBuilder.add(new ir.LetPrim(condition));
+ condition = condBuilder.buildBooleanLiteral(true);
} else {
condition = withBuilder(condBuilder, () => visit(node.condition));
}
@@ -1196,9 +1194,7 @@ class IrBuilderVisitor extends ResolvedVisitor<ir.Primitive>
// Do the modification of the value in getter.
ir.Primitive arg;
if (ast.Operator.INCREMENT_OPERATORS.contains(op.source)) {
- arg = irBuilder.makePrimConst(
- irBuilder.state.constantSystem.createInt(1));
- irBuilder.add(new ir.LetPrim(arg));
+ arg = irBuilder.buildIntegerLiteral(1);
} else {
arg = visit(getAssignArgument());
}
@@ -1276,9 +1272,7 @@ class IrBuilderVisitor extends ResolvedVisitor<ir.Primitive>
if (constant == null) {
constant = getConstantForNode(node);
}
- ir.Primitive primitive = irBuilder.makeConst(constant);
- irBuilder.add(new ir.LetPrim(primitive));
- return primitive;
+ return irBuilder.buildConstantLiteral(constant);
}
ir.FunctionDefinition makeSubFunction(ast.FunctionExpression node) {
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698