dart2js: restructure emitter.

dart2js: restructure emitter.

Collect information before hand, and then emit output units in one go.
First emit the deferred units since we need their hashes in the main unit.

There is still code that collects the output-unit of the emitted element, even though we know that it should/must be in the current output-unit. That code can be cleaned up in a later CL. We should not need to look up the output unit for any element in the old-emitter anymore.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41142

[floitsch, 2014-10-15 10:32:09]

floitsch@google.com changed reviewers:
+ johnniwinther@google.com

[floitsch, 2014-10-15 10:32:10]

I tried to upload patches for the individual functions, but not all of them make
it easier...

[Johnni Winther, 2014-10-16 08:04:50]

lgtm

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:33:
/// True, if the output contains a constant list.
Add that this is updated in [computeNeededConstants].

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
File
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart
(right):

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart:611:
Isolate.# = isolateProperties;  // isolatePropertiesName
Maybe we should change [js] to take a map of arguments like MessageKind:

js('Isolate.#{isolatePropertiesName} = isolateProperties;',
{'isolatePropertiesName': namer.isolatePropertiesName})

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart:1236:
CodeBuffer libraryDescriptorBuffer = buffer;
Remove and use [buffer] below.

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart:1308:
builder.toObjectInitializer();
Indent by 4.

[floitsch, 2014-10-16 11:53:36]

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:33:
/// True, if the output contains a constant list.
On 2014/10/16 08:04:50, Johnni Winther wrote:
> Add that this is updated in [computeNeededConstants].

Done.

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
File
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart
(right):

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart:611:
Isolate.# = isolateProperties;  // isolatePropertiesName
On 2014/10/16 08:04:50, Johnni Winther wrote:
> Maybe we should change [js] to take a map of arguments like MessageKind:
> 
> js('Isolate.#{isolatePropertiesName} = isolateProperties;',
> {'isolatePropertiesName': namer.isolatePropertiesName})

Thought the same thing.
I might look into this later this or next week.

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart:1236:
CodeBuffer libraryDescriptorBuffer = buffer;
On 2014/10/16 08:04:50, Johnni Winther wrote:
> Remove and use [buffer] below.

Was to make diff easier. Wasn't really worth it...
done.

https://codereview.chromium.org/656043003/diff/160001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart:1308:
builder.toObjectInitializer();
On 2014/10/16 08:04:50, Johnni Winther wrote:
> Indent by 4.

All the statements here actually fit on one line.

[floitsch, 2014-10-16 11:54:03]

Committed patchset #10 (id:180001) manually as 41142 (presubmit successful).