sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/class_emitter.dart - Issue 656043003: dart2js: restructure emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/class_emitter.dart

Issue 656043003: dart2js: restructure emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/class_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/class_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/class_emitter.dart

index dbd3611148135320bf8cfa99d4abfdf8fa99aaa0..13e2df190681008572bc6c6b58a45d41942953b3 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/class_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/class_emitter.dart

@@ -321,15 +321,10 @@ class ClassEmitter extends CodeEmitterHelper {

statics.add(property);

}

- Map<OutputUnit, ClassBuilder> classPropertyLists =

+ ClassBuilder classProperties =

emitter.elementDescriptors.remove(classElement);

- if (classPropertyLists != null) {

- for (ClassBuilder classProperties in classPropertyLists.values) {

- // TODO(sigurdm): What about deferred?

- if (classProperties != null) {

- statics.addAll(classProperties.properties);

- }

+ if (classProperties != null) {

+ statics.addAll(classProperties.properties);

}

if (!statics.isEmpty) {