pkg/shelf: handle errors when parsing HttpRequest in shelf_io

pkg/shelf: handle errors when parsing HttpRequest in shelf_io

BUG= https://code.google.com/p/dart/issues/detail?id=19985
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41941

[kevmoo, 2014-10-14 22:03:40]

kevmoo@google.com changed reviewers:
+ nweiz@google.com

[kevmoo, 2014-10-14 22:03:40]

I'm struggling with a way to test this. Thoughts appreciated

[nweiz, 2014-10-14 22:16:24]

You should be able to test this by manually opening a socket to the server and
feeding it a busted HTTP request.

https://codereview.chromium.org/654933005/diff/1/pkg/shelf/lib/shelf_io.dart
File pkg/shelf/lib/shelf_io.dart (right):

https://codereview.chromium.org/654933005/diff/1/pkg/shelf/lib/shelf_io.dart#...
pkg/shelf/lib/shelf_io.dart:58: shelfRequest =_fromHttpRequest(request);
I'd avoid the manual try/catch by just putting this in the [syncFuture] below.

[kevmoo, 2014-11-23 00:21:19]

PTAL

https://codereview.chromium.org/654933005/diff/1/pkg/shelf/lib/shelf_io.dart
File pkg/shelf/lib/shelf_io.dart (right):

https://codereview.chromium.org/654933005/diff/1/pkg/shelf/lib/shelf_io.dart#...
pkg/shelf/lib/shelf_io.dart:58: shelfRequest =_fromHttpRequest(request);
On 2014/10/14 22:16:24, nweiz wrote:
> I'd avoid the manual try/catch by just putting this in the [syncFuture] below.

I was trying to separate the two error cases–when parsing and when handling–so I
can generate two different error messages for the different cases.

[nweiz, 2014-11-24 20:55:21]

lgtm

https://codereview.chromium.org/654933005/diff/1/pkg/shelf/lib/shelf_io.dart
File pkg/shelf/lib/shelf_io.dart (right):

https://codereview.chromium.org/654933005/diff/1/pkg/shelf/lib/shelf_io.dart#...
pkg/shelf/lib/shelf_io.dart:58: shelfRequest =_fromHttpRequest(request);
On 2014/11/23 00:21:19, kevmoo wrote:
> On 2014/10/14 22:16:24, nweiz wrote:
> > I'd avoid the manual try/catch by just putting this in the [syncFuture]
below.
> 
> I was trying to separate the two error cases–when parsing and when handling–so
I
> can generate two different error messages for the different cases.

SGTM

Add a space after "=".

[kevmoo, 2014-11-24 21:04:31]

https://codereview.chromium.org/654933005/diff/1/pkg/shelf/lib/shelf_io.dart
File pkg/shelf/lib/shelf_io.dart (right):

https://codereview.chromium.org/654933005/diff/1/pkg/shelf/lib/shelf_io.dart#...
pkg/shelf/lib/shelf_io.dart:58: shelfRequest =_fromHttpRequest(request);
On 2014/11/24 20:55:20, nweiz wrote:
> On 2014/11/23 00:21:19, kevmoo wrote:
> > On 2014/10/14 22:16:24, nweiz wrote:
> > > I'd avoid the manual try/catch by just putting this in the [syncFuture]
> below.
> > 
> > I was trying to separate the two error cases–when parsing and when
handling–so
> I
> > can generate two different error messages for the different cases.
> 
> SGTM
> 
> Add a space after "=".

Done.

[kevmoo, 2014-11-24 21:04:46]

Committed patchset #7 (id:120001) manually as 41941 (presubmit successful).