Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: pkg/shelf/lib/shelf_io.dart

Issue 654933005: pkg/shelf: handle errors when parsing HttpRequest in shelf_io (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: nit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/shelf/CHANGELOG.md ('k') | pkg/shelf/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/shelf/lib/shelf_io.dart
diff --git a/pkg/shelf/lib/shelf_io.dart b/pkg/shelf/lib/shelf_io.dart
index c6853025bd94d39b665d319bef3a6dbc20474c82..878935f0a188a40d2a8df8675253414534ca2dda 100644
--- a/pkg/shelf/lib/shelf_io.dart
+++ b/pkg/shelf/lib/shelf_io.dart
@@ -53,7 +53,13 @@ void serveRequests(Stream<HttpRequest> requests, Handler handler) {
///
/// Returns a [Future] which completes when the request has been handled.
Future handleRequest(HttpRequest request, Handler handler) {
- var shelfRequest = _fromHttpRequest(request);
+ var shelfRequest;
+ try {
+ shelfRequest = _fromHttpRequest(request);
+ } catch (error, stackTrace) {
+ var response = _logError('Error parsing request.\n$error', stackTrace);
+ return _writeResponse(response, request.response);
+ }
// TODO(nweiz): abstract out hijack handling to make it easier to implement an
// adapter.
« no previous file with comments | « pkg/shelf/CHANGELOG.md ('k') | pkg/shelf/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698