Issue 652903006: Issue 21373. Fix for removing line info in case of exception (causes NPE in outline computer).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 652903006: Issue 21373. Fix for removing line info in case of exception (causes NPE in outline computer). (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Issue 21373. Fix for removing line info in case of exception (causes NPE in outline computer). I will update analysis_server/pubspec.yaml before commit. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=21373 Committed: https://code.google.com/p/dart/source/detail?r=41235

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -19 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/computer/computer_outline.dart	View	3 chunks	+9 lines, -12 lines	0 comments	Download
M	pkg/analysis_server/lib/src/operation/operation_analysis.dart	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/pubspec.yaml	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/analysis/notification_outline_test.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

scheglov

6 years, 2 months ago (2014-10-21 20:34:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41235 (presubmit successful).