pkg/analyzer/lib/src/generated/engine.dart - Issue 652903006: Issue 21373. Fix for removing line info in case of exception (causes NPE in outline computer).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 652903006: Issue 21373. Fix for removing line info in case of exception (causes NPE in outline computer). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/lib/src/generated/engine.dart

diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart

index 79220a5364e47c4dcb54368c202763635f59ce6c..ea758e79a78661fa3ca68d9aacd219e7ebec87e4 100644

--- a/pkg/analyzer/lib/src/generated/engine.dart

+++ b/pkg/analyzer/lib/src/generated/engine.dart

@@ -2010,7 +2010,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {

dartEntry.recordResolutionErrorInLibrary(

librarySource,

thrownException);

- _cache.remove(source);

}

if (source != librarySource) {

_workManager.add(source, SourcePriority.PRIORITY_PART);

« no previous file with comments | « pkg/analysis_server/test/analysis/notification_outline_test.dart ('k') | pkg/analyzer/pubspec.yaml » ('j') | no next file with comments »