Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 651993006: "pub get" doesn't choke on previously-cached unknown transformers. (Closed)

Created:
6 years, 2 months ago by nweiz
Modified:
6 years, 2 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, Bob Nystrom, dart-release_google.com
Visibility:
Public.

Description

"pub get" doesn't choke on previously-cached unknown transformers. BUG=https://code.google.com/p/dart/issues/detail?id=21298 R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=41087

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/transformer_cache.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/transformer/cache_test.dart View 1 3 chunks +57 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/pub_generated/test/transformer/cache_test.dart View 1 3 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
6 years, 2 months ago (2014-10-13 23:03:05 UTC) #2
Alan Knight
lgtm https://codereview.chromium.org/651993006/diff/1/sdk/lib/_internal/pub/lib/src/barback/transformer_cache.dart File sdk/lib/_internal/pub/lib/src/barback/transformer_cache.dart (right): https://codereview.chromium.org/651993006/diff/1/sdk/lib/_internal/pub/lib/src/barback/transformer_cache.dart#newcode58 sdk/lib/_internal/pub/lib/src/barback/transformer_cache.dart:58: log.fine("Old transformers: $_oldTransformers\nPackages: ${_graph.packages}"); 80 cols https://codereview.chromium.org/651993006/diff/1/sdk/lib/_internal/pub/test/transformer/cache_test.dart File ...
6 years, 2 months ago (2014-10-13 23:06:42 UTC) #3
nweiz
Code review changes.
6 years, 2 months ago (2014-10-13 23:07:53 UTC) #4
nweiz
https://codereview.chromium.org/651993006/diff/1/sdk/lib/_internal/pub/lib/src/barback/transformer_cache.dart File sdk/lib/_internal/pub/lib/src/barback/transformer_cache.dart (right): https://codereview.chromium.org/651993006/diff/1/sdk/lib/_internal/pub/lib/src/barback/transformer_cache.dart#newcode58 sdk/lib/_internal/pub/lib/src/barback/transformer_cache.dart:58: log.fine("Old transformers: $_oldTransformers\nPackages: ${_graph.packages}"); On 2014/10/13 23:06:42, Alan Knight ...
6 years, 2 months ago (2014-10-13 23:09:08 UTC) #5
nweiz
6 years, 2 months ago (2014-10-13 23:10:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:110001) manually as 41087 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698