sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart - Issue 651993006: "pub get" doesn't choke on previously-cached unknown transformers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart

Issue 651993006: "pub get" doesn't choke on previously-cached unknown transformers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/transformer/cache_test.dart ('k') | sdk/lib/_internal/pub_generated/test/transformer/cache_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart

diff --git a/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart b/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart

index 01cf03be002d0067b24173d6f18ed97f9c13d97c..a396d154588d3d0937a21168162122d1a1508ee2 100644

--- a/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart

+++ b/sdk/lib/_internal/pub_generated/lib/src/barback/transformer_cache.dart

@@ -19,6 +19,7 @@ class TransformerCache {

}

void clearIfOutdated(Set<String> changedPackages) {

var snapshotDependencies = unionAll(_oldTransformers.map((id) {

+ if (!_graph.packages.containsKey(id.package)) return new Set();

return _graph.transitiveDependencies(

id.package).map((package) => package.name).toSet();

}));