Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 651443006: filter invalid method invocation suggestions (Closed)

Created:
6 years, 2 months ago by danrubel
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

filter invalid method invocation suggestions and filter _ from local suggestions BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41159

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -8 lines) Patch
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 3 chunks +22 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 3 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 2 months ago (2014-10-16 21:10:43 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-16 21:13:09 UTC) #3
danrubel
6 years, 2 months ago (2014-10-16 21:25:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41159 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698