filter invalid method invocation suggestions

pkg/analysis_server/lib/src/services/completion/local_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.local;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart' as protocol show Element,
     ElementKind;
@@ skipping 195 matching lines @@
     visitNode(node);
   }
 
   @override
   visitMethodDeclaration(MethodDeclaration node) {
     _addParamListSuggestions(node.parameters);
     visitNode(node);
   }
 
   @override
+  visitMethodInvocation(MethodInvocation node) {
+    // InvocationComputer adds suggestions for method selector
+    Token period = node.period;
+    if (period != null && period.offset < request.offset) {
+      ArgumentList argumentList = node.argumentList;
+      if (argumentList == null || request.offset <= argumentList.offset) {
+        return;
+      }
+    }
+    visitNode(node);
+  }
+
+  @override
   visitNamespaceDirective(NamespaceDirective node) {
     // No suggestions
   }
 
   @override
   visitNode(AstNode node) {
     node.parent.accept(this);
   }
 
   @override
@@ skipping 140 matching lines @@
       csKind = CompletionSuggestionKind.SETTER;
     } else {
       if (excludeVoidReturn && _isVoid(classMbr.returnType)) {
         return;
       }
       kind = protocol.ElementKind.METHOD;
       csKind = CompletionSuggestionKind.METHOD;
     }
     CompletionSuggestion suggestion =
         _addSuggestion(classMbr.name, csKind, classMbr.returnType, node);
-    suggestion.element = _createElement(
-        kind,
-        classMbr.name,
-        classMbr.returnType,
-        classMbr.isAbstract,
-        _isDeprecated(classMbr.metadata));
+    if (suggestion != null) {
+      suggestion.element = _createElement(
+          kind,
+          classMbr.name,
+          classMbr.returnType,
+          classMbr.isAbstract,
+          _isDeprecated(classMbr.metadata));
+    }
   }
 
   void _addParamListSuggestions(FormalParameterList paramList) {
     if (typesOnly) {
       return;
     }
     if (paramList != null) {
       paramList.parameters.forEach((FormalParameter param) {
         NormalFormalParameter normalParam;
         if (param is DefaultFormalParameter) {
@@ skipping 23 matching lines @@
     if (suggestion != null) {
       suggestion.element =
           _createElement(protocol.ElementKind.PARAMETER, identifier, type, false, false);
     }
   }
 
   CompletionSuggestion _addSuggestion(SimpleIdentifier id,
       CompletionSuggestionKind kind, TypeName typeName, ClassDeclaration classDecl) {
     if (id != null) {
       String completion = id.name;
-      if (completion != null && completion.length > 0) {
+      if (completion != null && completion.length > 0 && completion != '_') {
         CompletionSuggestion suggestion = new CompletionSuggestion(
             kind,
             CompletionRelevance.DEFAULT,
             completion,
             completion.length,
             0,
             false,
             false);
         if (classDecl != null) {
           SimpleIdentifier identifier = classDecl.name;
@@ skipping 107 matching lines @@
     if (name == null || name.length <= 0) {
       return DYNAMIC;
     }
     TypeArgumentList typeArgs = type.typeArguments;
     if (typeArgs != null) {
       //TODO (danrubel) include type arguments
     }
     return name;
   }
 }