Type check field assignments during constant evaluation.

Type check field assignments during constant evaluation.

BUG=dartbug.com/16391
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41062

[Paul Berry, 2014-10-11 16:38:19]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2014-10-11 19:44:57]

LGTM

[Paul Berry, 2014-10-11 21:25:16]

Committed patchset #1 (id:1) manually as 41062 (presubmit successful).

[Brian Wilkerson, 2014-10-12 20:20:42]

https://codereview.chromium.org/644283002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/constant.dart (right):

https://codereview.chromium.org/644283002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/constant.dart:778: PropertyAccessorElement getter
= definingClass.getGetter(fieldName);
Seems like we should need to check for "getter != null" before using it. In
invalid code we can have a field initializer that doesn't correspond to a field.
We might also want to confirm that the field is not synthetic and refrain from
issuing an error in that case.

[Paul Berry, 2014-10-13 15:55:33]

https://codereview.chromium.org/644283002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/constant.dart (right):

https://codereview.chromium.org/644283002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/constant.dart:778: PropertyAccessorElement getter
= definingClass.getGetter(fieldName);
On 2014/10/12 20:20:42, Brian Wilkerson wrote:
> Seems like we should need to check for "getter != null" before using it. In
> invalid code we can have a field initializer that doesn't correspond to a
field.
> We might also want to confirm that the field is not synthetic and refrain from
> issuing an error in that case.

That's a good point.  I'll add tests for these cases and fix the code as
necessary.