Type check field assignments during constant evaluation.

pkg/analyzer/lib/src/generated/constant.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.constant;
 
 import 'dart:collection';
@@ skipping 757 matching lines @@
     String superName = null;
     NodeList<Expression> superArguments = null;
     for (ConstructorInitializer initializer in initializers) {
       if (initializer is ConstructorFieldInitializer) {
         ConstructorFieldInitializer constructorFieldInitializer = initializer;
         Expression initializerExpression = constructorFieldInitializer.expression;
         DartObjectImpl evaluationResult = initializerExpression.accept(initializerVisitor);
         if (evaluationResult != null) {
           String fieldName = constructorFieldInitializer.fieldName.name;
           fieldMap[fieldName] = evaluationResult;
+          PropertyAccessorElement getter = definingClass.getGetter(fieldName);

[Brian Wilkerson, 2014/10/12 20:20:42]

Seems like we should need to check for "getter != null" before using it. In
invalid code we can have a field initializer that doesn't correspond to a field.
We might also want to confirm that the field is not synthetic and refrain from
issuing an error in that case.

[Paul Berry, 2014/10/13 15:55:33]

That's a good point.  I'll add tests for these cases and fix the code as
necessary.

+          PropertyInducingElement field = getter.variable;
+          if (!evaluationResult.isNull &&
+              !evaluationResult.type.isSubtypeOf(field.type)) {
+            errorReporter.reportErrorForNode(
+                CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_FIELD_TYPE_MISMATCH,
+                node, [evaluationResult.type, fieldName, field.type]);
+          }
         }
       } else if (initializer is SuperConstructorInvocation) {
         SuperConstructorInvocation superConstructorInvocation = initializer;
         SimpleIdentifier name = superConstructorInvocation.constructorName;
         if (name != null) {
           superName = name.name;
         }
         superArguments = superConstructorInvocation.argumentList.arguments;
       }
     }
@@ skipping 3846 matching lines @@
 
   @override
   String get typeName => "Type";
 
   @override
   int get hashCode => _element == null ? 0 : _element.hashCode;
 
   @override
   String toString() => _element == null ? "-unknown-" : _element.name;
 }