Implement bigint mulAdd and sqrAdd intrinsics on ARM.

Implement bigint mulAdd and sqrAdd intrinsics on ARM.
Add support for umaal instruction on ARM (assembler, disassembler, simulator).
Add assembler test for umaal instruction on ARM.

R=johnmccutchan@google.com, zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40993

[regis, 2014-10-08 15:05:27]

regis@google.com changed reviewers:
+ johnmccutchan@google.com, zra@google.com

[Cutch, 2014-10-08 15:22:26]

lgtm

https://codereview.chromium.org/638983002/diff/1/runtime/vm/intrinsifier_arm.cc
File runtime/vm/intrinsifier_arm.cc (right):

https://codereview.chromium.org/638983002/diff/1/runtime/vm/intrinsifier_arm....
runtime/vm/intrinsifier_arm.cc:916: if (TargetCPUFeatures::arm_version() !=
ARMv7) return;
if (TargetCPUFeatures::arm_version() != ARMv7) {
  return;
}

here and elsewhere.

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc#...
runtime/vm/simulator_arm.cc:1800: } else {
ASSERT(instr->Bits(21, 3) == 2);

[zra, 2014-10-08 15:54:46]

lgtm

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc#...
runtime/vm/simulator_arm.cc:1795: result = accum + left_op * right_op;  //
Unsigned nultiplication.
multiplication

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc#...
runtime/vm/simulator_arm.cc:1799: result = accum + left_op * right_op;  //
Signed nultiplication.
multiplication

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc#...
runtime/vm/simulator_arm.cc:1803: result = left_op * right_op +  // Unsigned
nultiplication.
multiplication

[regis, 2014-10-08 16:58:00]

Thanks!

https://codereview.chromium.org/638983002/diff/1/runtime/vm/intrinsifier_arm.cc
File runtime/vm/intrinsifier_arm.cc (right):

https://codereview.chromium.org/638983002/diff/1/runtime/vm/intrinsifier_arm....
runtime/vm/intrinsifier_arm.cc:916: if (TargetCPUFeatures::arm_version() !=
ARMv7) return;
On 2014/10/08 15:22:26, Cutch wrote:
> if (TargetCPUFeatures::arm_version() != ARMv7) {
>   return;
> }
> 
> here and elsewhere.

Done.

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc#...
runtime/vm/simulator_arm.cc:1795: result = accum + left_op * right_op;  //
Unsigned nultiplication.
On 2014/10/08 15:54:46, zra wrote:
> multiplication

Done.

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc#...
runtime/vm/simulator_arm.cc:1799: result = accum + left_op * right_op;  //
Signed nultiplication.
On 2014/10/08 15:54:46, zra wrote:
> multiplication

Done.

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc#...
runtime/vm/simulator_arm.cc:1800: } else {
On 2014/10/08 15:22:26, Cutch wrote:
> ASSERT(instr->Bits(21, 3) == 2);

Done.

https://codereview.chromium.org/638983002/diff/1/runtime/vm/simulator_arm.cc#...
runtime/vm/simulator_arm.cc:1803: result = left_op * right_op +  // Unsigned
nultiplication.
On 2014/10/08 15:54:46, zra wrote:
> multiplication

Done.

[regis, 2014-10-08 17:00:05]

Committed patchset #2 (id:20001) manually as r40993.