Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 635043002: show only type names in is expression RHS (Closed)

Created:
6 years, 2 months ago by danrubel
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

show only type names in is expression RHS BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40977

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -104 lines) Patch
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 6 chunks +25 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 12 chunks +49 lines, -21 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 2 chunks +23 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 2 chunks +0 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 2 months ago (2014-10-07 20:09:09 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-07 20:15:17 UTC) #3
danrubel
6 years, 2 months ago (2014-10-07 20:24:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698