show only type names in is expression RHS

pkg/analysis_server/lib/src/services/completion/imported_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.toplevel;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol_server.dart' hide Element,
     ElementKind;
@@ skipping 34 matching lines @@
   final DartCompletionRequest request;
 
   _ImportedVisitor(this.request);
 
   @override
   Future<bool> visitBlock(Block node) {
     return _addImportedElementSuggestions();
   }
 
   @override
+  Future<bool> visitCascadeExpression(CascadeExpression node) {
+    // Make suggestions for the target, but not for the selector
+    // InvocationComputer makes selector suggestions
+    Expression target = node.target;
+    if (target != null && request.offset <= target.end) {
+      return _addImportedElementSuggestions();
+    }
+    return new Future.value(false);
+  }
+
+  @override
   Future<bool> visitCombinator(Combinator node) {
     return _addCombinatorSuggestions(node);
   }
 
   @override
   Future<bool> visitExpressionStatement(ExpressionStatement node) {
     Expression expression = node.expression;
     // A pre-variable declaration (e.g. C ^) is parsed as an expression
     // statement. Do not make suggestions for the variable name.
     if (expression is SimpleIdentifier && request.offset <= expression.end) {
@@ skipping 11 matching lines @@
   Future<bool> visitPrefixedIdentifier(PrefixedIdentifier node) {
     // Make suggestions for the prefix, but not for the selector
     // InvocationComputer makes selector suggestions
     if (request.offset <= node.prefix.end) {
       return _addImportedElementSuggestions();
     }
     return new Future.value(false);
   }
 
   @override
-  Future<bool> visitCascadeExpression(CascadeExpression node) {
-    // Make suggestions for the target, but not for the selector
-    // InvocationComputer makes selector suggestions
-    Expression target = node.target;
-    if (target != null && request.offset <= target.end) {
-      return _addImportedElementSuggestions();
-    }
-    return new Future.value(false);
-  }
-
-  @override
   Future<bool> visitSimpleIdentifier(SimpleIdentifier node) {
     return node.parent.accept(this);
   }
 
+  @override
+  Future<bool> visitTypeName(TypeName node) {
+    return _addImportedElementSuggestions(typesOnly: true);
+  }
+
   Future _addCombinatorSuggestions(Combinator node) {
     var directive = node.getAncestor((parent) => parent is NamespaceDirective);
     if (directive is NamespaceDirective) {
       LibraryElement library = directive.uriElement;
       LibraryElementSuggestionBuilder.suggestionsFor(request, library);
       return new Future.value(true);
     }
 
     return new Future.value(false);
   }
@@ skipping 25 matching lines @@
     if (type != null) {
       String name = type.displayName;
       if (name != null && name.length > 0 && name != 'dynamic') {
         suggestion.returnType = name;
       }
     }
 
     request.suggestions.add(suggestion);
   }
 
-  Future<bool> _addImportedElementSuggestions() {
+  Future<bool> _addImportedElementSuggestions({bool typesOnly: false}) {
 
     // Exclude elements from local library
     // because they are provided by LocalComputer
     Set<LibraryElement> excludedLibs = new Set<LibraryElement>();
     excludedLibs.add(request.unit.element.enclosingElement);
 
     // Include explicitly imported elements
     request.unit.directives.forEach((Directive directive) {
       if (directive is ImportDirective) {
         ImportElement importElem = directive.element;
         if (importElem != null && importElem.importedLibrary != null) {
           if (directive.prefix == null) {
             Namespace importNamespace =
                 new NamespaceBuilder().createImportNamespaceForDirective(importElem);
             importNamespace.definedNames.forEach((_, Element element) {
-              _addElementSuggestion(element, CompletionRelevance.DEFAULT);
+              if (!typesOnly || element is ClassElement) {
+                _addElementSuggestion(element, CompletionRelevance.DEFAULT);
+              }
             });
           } else {
             // Exclude elements from prefixed imports
             // because they are provided by InvocationComputer
             excludedLibs.add(importElem.importedLibrary);
             _addLibraryPrefixSuggestion(importElem);
           }
         }
       }
     });
 
     // Include implicitly imported dart:core elements
     Source coreUri = request.context.sourceFactory.forUri('dart:core');
     LibraryElement coreLib = request.context.getLibraryElement(coreUri);
     Namespace coreNamespace =
         new NamespaceBuilder().createPublicNamespaceForLibrary(coreLib);
     coreNamespace.definedNames.forEach((_, Element element) {
-      _addElementSuggestion(element, CompletionRelevance.DEFAULT);
+      if (!typesOnly || element is ClassElement) {
+        _addElementSuggestion(element, CompletionRelevance.DEFAULT);
+      }
     });
 
     // Add non-imported elements as low relevance
     var future = request.searchEngine.searchTopLevelDeclarations('');
     return future.then((List<SearchMatch> matches) {
       Set<String> completionSet = new Set<String>();
       request.suggestions.forEach((CompletionSuggestion suggestion) {
         completionSet.add(suggestion.completion);
       });
       matches.forEach((SearchMatch match) {
         if (match.kind == MatchKind.DECLARATION) {
           Element element = match.element;
           if (element.isPublic &&
               !excludedLibs.contains(element.library) &&
               !completionSet.contains(element.displayName)) {
-            _addElementSuggestion(element, CompletionRelevance.LOW);
+            if (!typesOnly || element is ClassElement) {
+              _addElementSuggestion(element, CompletionRelevance.LOW);
+            }
           }
         }
       });
       return true;
     });
   }
 
   void _addLibraryPrefixSuggestion(ImportElement importElem) {
     String completion = importElem.prefix.displayName;
     if (completion != null && completion.length > 0) {
       CompletionSuggestion suggestion = new CompletionSuggestion(
           CompletionSuggestionKind.LIBRARY_PREFIX,
           CompletionRelevance.DEFAULT,
           completion,
           completion.length,
           0,
           importElem.isDeprecated,
           false);
       LibraryElement lib = importElem.importedLibrary;
       if (lib != null) {
         suggestion.element = newElement_fromEngine(lib);
       }
       request.suggestions.add(suggestion);
     }
   }
 }