Issue 63303002: Stopgap generating docgen all at once until --append mode can be fixed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63303002: Stopgap generating docgen all at once until --append mode can be fixed (Closed)

Created:
7 years, 1 month ago by Alan Knight

Modified:
7 years, 1 month ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Stopgap generating docgen all at once until --append mode can be fixed R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=30009

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -6 lines)			Patch
M	pkg/docgen/bin/dartdoc.py	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	pkg/docgen/bin/docgen.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/docgen/lib/docgen.dart	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm with adjustment https://codereview.chromium.org/63303002/diff/1/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/63303002/diff/1/pkg/docgen/lib/docgen.dart#newcode308 pkg/docgen/lib/docgen.dart:308: if (includeSdk) (entityMap['dart-core.Object'] as Class).subclasses.clear(); if ...

7 years, 1 month ago (2013-11-06 22:29:25 UTC) #2

Alan Knight

https://codereview.chromium.org/63303002/diff/1/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/63303002/diff/1/pkg/docgen/lib/docgen.dart#newcode308 pkg/docgen/lib/docgen.dart:308: if (includeSdk) (entityMap['dart-core.Object'] as Class).subclasses.clear(); On 2013/11/06 22:29:26, Emily ...

7 years, 1 month ago (2013-11-06 23:16:30 UTC) #3

Alan Knight

7 years, 1 month ago (2013-11-06 23:17:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r30009 (presubmit successful).

Expand Messages | Collapse Messages