Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: pkg/docgen/bin/dartdoc.py

Issue 63303002: Stopgap generating docgen all at once until --append mode can be fixed (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/docgen/bin/docgen.dart » ('j') | pkg/docgen/lib/docgen.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/docgen/bin/dartdoc.py
diff --git a/pkg/docgen/bin/dartdoc.py b/pkg/docgen/bin/dartdoc.py
index da20cd829aa40ddfc4fb0d01df7b3c2a793ead0f..09da94853c5d53ecbace56d23c291659a0ee8479 100644
--- a/pkg/docgen/bin/dartdoc.py
+++ b/pkg/docgen/bin/dartdoc.py
@@ -82,12 +82,13 @@ def GenerateAllDocs(docgen_options):
'''Generate all documentation for the SDK and all packages in the repository.
We first attempt to run the quickest path to generate all docs, but if that
fails, we fall back on a slower option.'''
- sdk_cmd = [DART_EXECUTABLE, 'docgen.dart', '--parse-sdk']
- ExecuteCommand(AddUserDocgenOptions(sdk_cmd, docgen_options))
-
+# TODO(alanknight): The --append option doesn't work properly. It overwrites
+# existing files with new information. Known symptom is that it loses subclasses
+# from the SDK and includes only the ones from pkg. So right now our only option
+# is to do everything in one pass.
doc_dir = join(DART_DIR, 'pkg')
cmd_lst = [DART_EXECUTABLE, '--old_gen_heap_size=1024',
- '--package-root=%s' % PACKAGE_ROOT, 'docgen.dart', '--append']
+ '--package-root=%s' % PACKAGE_ROOT, 'docgen.dart', '--include-sdk' ]
cmd_str = ' '.join(AddUserDocgenOptions(cmd_lst, docgen_options, True))
# Try to run all pkg docs together at once as it's fastest.
(return_code, _) = ExecuteCommandString('%s %s' % (cmd_str, doc_dir))
« no previous file with comments | « no previous file | pkg/docgen/bin/docgen.dart » ('j') | pkg/docgen/lib/docgen.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698