Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Issue 631013002: Avoid verifying heap while sweeper is running. (Closed)

Created:
6 years, 2 months ago by koda
Modified:
6 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Avoid verifying heap while sweeper is running. Verifier cannot handle a combination of dead+unswept objects and dead+swept objects. * Verify before marking, before sweeping, and after a non-concurrent sweep. * Disable pre/post-scavenge verification when concurrently sweeping. * On shutdown, wait until concurrent GC tasks finish before verifying. R=iposva@google.com TBR=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40946

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -14 lines) Patch
M runtime/vm/isolate.cc View 1 1 chunk +11 lines, -1 line 0 comments Download
M runtime/vm/pages.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M runtime/vm/scavenger.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
Submitting TBR to allow another attempt at enabling --concurrent_sweep (in DEBUG mode, we always verify ...
6 years, 2 months ago (2014-10-06 23:16:46 UTC) #1
Ivan Posva
LGTM -ip
6 years, 2 months ago (2014-10-06 23:20:07 UTC) #2
koda
6 years, 2 months ago (2014-10-06 23:20:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r40946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698