Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1751)

Unified Diff: runtime/vm/scavenger.cc

Issue 631013002: Avoid verifying heap while sweeper is running. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/pages.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scavenger.cc
===================================================================
--- runtime/vm/scavenger.cc (revision 40943)
+++ runtime/vm/scavenger.cc (working copy)
@@ -797,10 +797,10 @@
PageSpace* page_space = heap_->old_space();
NoHandleScope no_handles(isolate);
- if (FLAG_verify_before_gc) {
+ // TODO(koda): Make verification more compatible with concurrent sweep.
+ if (FLAG_verify_before_gc && !FLAG_concurrent_sweep) {
OS::PrintErr("Verifying before Scavenge...");
- // TODO(koda): Check whether sweeper is actually running.
- heap_->Verify(FLAG_concurrent_sweep ? kAllowMarked : kForbidMarked);
+ heap_->Verify(kForbidMarked);
OS::PrintErr(" done.\n");
}
@@ -837,10 +837,10 @@
visitor.bytes_promoted() >> kWordSizeLog2));
Epilogue(isolate, &visitor, invoke_api_callbacks);
- if (FLAG_verify_after_gc) {
+ // TODO(koda): Make verification more compatible with concurrent sweep.
+ if (FLAG_verify_after_gc && !FLAG_concurrent_sweep) {
OS::PrintErr("Verifying after Scavenge...");
- // TODO(koda): Check whether sweeper is actually running.
- heap_->Verify(FLAG_concurrent_sweep ? kAllowMarked : kForbidMarked);
+ heap_->Verify(kForbidMarked);
OS::PrintErr(" done.\n");
}
« no previous file with comments | « runtime/vm/pages.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698