Issue 630933002: Check mark bit when verifying heap.

Issue 630933002: Check mark bit when verifying heap. (Closed)

Created:
6 years, 2 months ago by koda

Modified:
6 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Check mark bit when verifying heap. Verify expected state of mark bit, depending on: - pre vs. post-GC - VM vs. regular isolate - concurrent vs. regular sweep Committed: https://code.google.com/p/dart/source/detail?r=40943

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -18 lines)			Patch
M	runtime/vm/heap.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/heap.cc	View	1 2 3 4 5	2 chunks	+15 lines, -8 lines	0 comments	Download
M	runtime/vm/pages.cc	View	4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/scavenger.cc	View	1 2 3	3 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/verifier.h	View	1	2 chunks	+15 lines, -3 lines	0 comments	Download
M	runtime/vm/verifier.cc	View	1	2 chunks	+21 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -ip https://codereview.chromium.org/630933002/diff/40001/runtime/vm/heap.cc File runtime/vm/heap.cc (right): https://codereview.chromium.org/630933002/diff/40001/runtime/vm/heap.cc#newcode474 runtime/vm/heap.cc:474: mark_expectation); How about? ... object_visitor( isolate(), allocated_set, ...

6 years, 2 months ago (2014-10-06 18:38:08 UTC) #2

koda

https://codereview.chromium.org/630933002/diff/40001/runtime/vm/heap.cc File runtime/vm/heap.cc (right): https://codereview.chromium.org/630933002/diff/40001/runtime/vm/heap.cc#newcode474 runtime/vm/heap.cc:474: mark_expectation); On 2014/10/06 18:38:08, Ivan Posva wrote: > How ...

6 years, 2 months ago (2014-10-06 19:24:30 UTC) #3

koda

6 years, 2 months ago (2014-10-06 19:24:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #6 (id:100001) manually as r40943 (presubmit successful).

Expand Messages | Collapse Messages