Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: runtime/vm/scavenger.cc

Issue 630933002: Check mark bit when verifying heap. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/pages.cc ('k') | runtime/vm/verifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scavenger.cc
===================================================================
--- runtime/vm/scavenger.cc (revision 40925)
+++ runtime/vm/scavenger.cc (working copy)
@@ -28,6 +28,7 @@
DEFINE_FLAG(int, new_gen_garbage_threshold, 90,
"Grow new gen when less than this percentage is garbage.");
DEFINE_FLAG(int, new_gen_growth_factor, 4, "Grow new gen by this factor.");
+DECLARE_FLAG(bool, concurrent_sweep);
// Scavenger uses RawObject::kMarkBit to distinguish forwaded and non-forwarded
// objects. The kMarkBit does not intersect with the target address because of
@@ -798,7 +799,8 @@
if (FLAG_verify_before_gc) {
OS::PrintErr("Verifying before Scavenge...");
- heap_->Verify();
+ // TODO(koda): Check whether sweeper is actually running.
+ heap_->Verify(FLAG_concurrent_sweep ? kAllowMarked : kForbidMarked);
OS::PrintErr(" done.\n");
}
@@ -837,7 +839,8 @@
if (FLAG_verify_after_gc) {
OS::PrintErr("Verifying after Scavenge...");
- heap_->Verify();
+ // TODO(koda): Check whether sweeper is actually running.
+ heap_->Verify(FLAG_concurrent_sweep ? kAllowMarked : kForbidMarked);
OS::PrintErr(" done.\n");
}
« no previous file with comments | « runtime/vm/pages.cc ('k') | runtime/vm/verifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698