Stop sending launchData for non-analyzed files

Stop sending launchData for non-analyzed files

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40942

[Brian Wilkerson, 2014-10-06 16:44:00]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2014-10-06 16:51:44]

lgtm

https://codereview.chromium.org/630863003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/domain_execution.dart (right):

https://codereview.chromium.org/630863003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_execution.dart:145: if
(!server.contextDirectoryManager.isInAnalysisRoot(filePath)) {
You could extract "server.contextDirectoryManager.isInAnalysisRoot(filePath)"
into a this class method with a shorter name and avoid code duplication.

https://codereview.chromium.org/630863003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_execution.dart:187: }
The whole "if" statement could be extracted into a class member or a local
function.

https://codereview.chromium.org/630863003/diff/1/pkg/analysis_server/test/dom...
File pkg/analysis_server/test/domain_execution_test.dart (right):

https://codereview.chromium.org/630863003/diff/1/pkg/analysis_server/test/dom...
pkg/analysis_server/test/domain_execution_test.dart:181:
when(manager.isInAnalysisRoot(anyObject)).thenInvoke((String path) {
You could use anyString instead, if the argument is a String.

You could use thenReturn(true) if you don't need to change arguments.

[Brian Wilkerson, 2014-10-06 18:56:20]

https://codereview.chromium.org/630863003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/domain_execution.dart (right):

https://codereview.chromium.org/630863003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_execution.dart:145: if
(!server.contextDirectoryManager.isInAnalysisRoot(filePath)) {
Done

https://codereview.chromium.org/630863003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_execution.dart:187: }
Done

https://codereview.chromium.org/630863003/diff/1/pkg/analysis_server/test/dom...
File pkg/analysis_server/test/domain_execution_test.dart (right):

https://codereview.chromium.org/630863003/diff/1/pkg/analysis_server/test/dom...
pkg/analysis_server/test/domain_execution_test.dart:181:
when(manager.isInAnalysisRoot(anyObject)).thenInvoke((String path) {
Done

[Brian Wilkerson, 2014-10-06 18:56:37]

Committed patchset #2 (id:20001) manually as 40942 (presubmit successful).