Stop sending launchData for non-analyzed files

pkg/analysis_server/lib/src/domain_execution.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library domain.execution;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/analysis_server.dart';
@@ skipping 124 matching lines @@
         onFileAnalyzed.cancel();
         onFileAnalyzed = null;
       }
     }
     return new ExecutionSetSubscriptionsResult().toResponse(request.id);
   }
 
   void _fileAnalyzed(ChangeNotice notice) {
     Source source = notice.source;
     String filePath = source.fullName;
+    if (!server.contextDirectoryManager.isInAnalysisRoot(filePath)) {

[scheglov, 2014/10/06 16:51:44]

You could extract "server.contextDirectoryManager.isInAnalysisRoot(filePath)"
into a this class method with a shorter name and avoid code duplication.

[Brian Wilkerson, 2014/10/06 18:56:20]

Done

+      return;
+    }
     AnalysisContext context = server.getAnalysisContext(filePath);
     if (AnalysisEngine.isDartFileName(filePath)) {
       ExecutableKind kind = ExecutableKind.NOT_EXECUTABLE;
       if (context.isClientLibrary(source)) {
         kind = ExecutableKind.CLIENT;
         if (context.isServerLibrary(source)) {
           kind = ExecutableKind.EITHER;
         }
       } else if (context.isServerLibrary(source)) {
         kind = ExecutableKind.SERVER;
@@ skipping 12 matching lines @@
   }
 
   void _reportCurrentFileStatus() {
     Map<String, List<String>> dartToHtml = new HashMap<String, List<String>>();
     Map<String, List<String>> htmlToDart = new HashMap<String, List<String>>();
     for (AnalysisContext context in server.getAnalysisContexts()) {
       List<Source> librarySources = context.librarySources;
       List<Source> clientSources = context.launchableClientLibrarySources;
       List<Source> serverSources = context.launchableServerLibrarySources;
       for (Source source in clientSources) {
+        String filePath = source.fullName;
         if (serverSources.remove(source)) {
-          server.sendNotification(
-              new ExecutionLaunchDataParams(
-                  source.fullName,
-                  kind: ExecutableKind.EITHER).toNotification());
+          if (server.contextDirectoryManager.isInAnalysisRoot(filePath)) {
+            server.sendNotification(
+                new ExecutionLaunchDataParams(
+                    filePath,
+                    kind: ExecutableKind.EITHER).toNotification());
+          }

[scheglov, 2014/10/06 16:51:44]

The whole "if" statement could be extracted into a class member or a local
function.

[Brian Wilkerson, 2014/10/06 18:56:20]

Done

         } else {
-          server.sendNotification(
-              new ExecutionLaunchDataParams(
-                  source.fullName,
-                  kind: ExecutableKind.CLIENT).toNotification());
+          if (server.contextDirectoryManager.isInAnalysisRoot(filePath)) {
+            server.sendNotification(
+                new ExecutionLaunchDataParams(
+                    filePath,
+                    kind: ExecutableKind.CLIENT).toNotification());
+          }
         }
         librarySources.remove(source);
       }
       for (Source source in serverSources) {
-        server.sendNotification(
-            new ExecutionLaunchDataParams(
-                source.fullName,
-                kind: ExecutableKind.SERVER).toNotification());
+        String filePath = source.fullName;
+        if (server.contextDirectoryManager.isInAnalysisRoot(filePath)) {
+          server.sendNotification(
+              new ExecutionLaunchDataParams(
+                  filePath,
+                  kind: ExecutableKind.SERVER).toNotification());
+        }
         librarySources.remove(source);
       }
       for (Source source in librarySources) {
-        server.sendNotification(
-            new ExecutionLaunchDataParams(
-                source.fullName,
-                kind: ExecutableKind.NOT_EXECUTABLE).toNotification());
+        String filePath = source.fullName;
+        if (server.contextDirectoryManager.isInAnalysisRoot(filePath)) {
+          server.sendNotification(
+              new ExecutionLaunchDataParams(
+                  filePath,
+                  kind: ExecutableKind.NOT_EXECUTABLE).toNotification());
+        }
       }
       for (Source source in context.htmlSources) {
-        List<Source> libraries = context.getLibrariesReferencedFromHtml(source);
-        server.sendNotification(
-            new ExecutionLaunchDataParams(
-                source.fullName,
-                referencedFiles: _getFullNames(libraries)).toNotification());
+        String filePath = source.fullName;
+        if (server.contextDirectoryManager.isInAnalysisRoot(filePath)) {
+          List<Source> libraries = context.getLibrariesReferencedFromHtml(source);
+          server.sendNotification(
+              new ExecutionLaunchDataParams(
+                  filePath,
+                  referencedFiles: _getFullNames(libraries)).toNotification());
+          }
       }
     }
   }
 
   static List<String> _getFullNames(List<Source> sources) {
     return sources.map((Source source) => source.fullName).toList();
   }
 }